Skip to content

fix(contacts): allow address book to be local but not system#56240

Merged
ArtificialOwl merged 1 commit intomasterfrom
fix/noid/set-adr-book-local-but-not-system
Jan 5, 2026
Merged

fix(contacts): allow address book to be local but not system#56240
ArtificialOwl merged 1 commit intomasterfrom
fix/noid/set-adr-book-local-but-not-system

Conversation

@ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Nov 6, 2025 •
edited
Loading

if set as local system address book, a userId is expected in some place like

server/lib/private/Collaboration/Collaborators/MailPlugin.php

Lines 114 to 134 in 77194d5

if (isset($contact['isLocalSystemBook'])) {
if ($this->shareWithGroupOnly) {
/*
* Check if the user may share with the user associated with the e-mail of the just found contact
*/
$userGroups = $this->groupManager->getUserGroupIds($this->userSession->getUser());
// ShareWithGroupOnly filtering
$userGroups = array_diff($userGroups, $this->shareWithGroupOnlyExcludeGroupsList);
$found = false;
foreach ($userGroups as $userGroup) {
if ($this->groupManager->isInGroup($contact['UID'], $userGroup)) {
$found = true;
break;
}
}
if (!$found) {
continue;
}
}

This fix allow app like ldap_contacts_backend to using a new configuration key to set itself as a local non-system address book

nextcloud/ldap_contacts_backend#350

@ArtificialOwl ArtificialOwl mentioned this pull request Nov 6, 2025
Merged
1 task
@blizzz
Copy link
Member

blizzz commented Nov 11, 2025

could we find a positive name, that describes what it is? isVirtualAdressbook or something like this?

@ArtificialOwl ArtificialOwl force-pushed the fix/noid/set-adr-book-local-but-not-system branch from 3fe5a94 to bd6fb93 Compare November 12, 2025 11:32
@ArtificialOwl
Copy link
Member Author

ArtificialOwl commented Nov 12, 2025

could we find a positive name, that describes what it is? isVirtualAdressbook or something like this?

totally agree; fun fact, I had the exact same name in mind but forgot to force push :D

@ArtificialOwl ArtificialOwl marked this pull request as ready for review November 12, 2025 11:45
@ArtificialOwl ArtificialOwl requested a review from a team as a code owner November 12, 2025 11:45
@ArtificialOwl ArtificialOwl requested review from CarlSchwan, icewind1991 and salmart-dev and removed request for a team November 12, 2025 11:45
@ArtificialOwl ArtificialOwl force-pushed the fix/noid/set-adr-book-local-but-not-system branch from bd6fb93 to 6edf519 Compare November 19, 2025 14:44
@ArtificialOwl ArtificialOwl force-pushed the fix/noid/set-adr-book-local-but-not-system branch from 6edf519 to b2a3448 Compare November 19, 2025 14:45
@ArtificialOwl ArtificialOwl force-pushed the fix/noid/set-adr-book-local-but-not-system branch 2 times, most recently from 10824a4 to 8202cd9 Compare December 22, 2025 12:58
@ArtificialOwl
fix(contacts): not contact, not local
b281764 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl ArtificialOwl force-pushed the fix/noid/set-adr-book-local-but-not-system branch from 8202cd9 to b281764 Compare December 22, 2025 13:37
@ArtificialOwl ArtificialOwl merged commit eb03697 into master Jan 5, 2026
195 checks passed
@ArtificialOwl ArtificialOwl deleted the fix/noid/set-adr-book-local-but-not-system branch January 5, 2026 10:55
@come-nc come-nc added this to the Nextcloud 33 milestone Jan 5, 2026
@come-nc come-nc added enhancement 4. to release Ready to be released and/or waiting for tests to finish feature: contacts labels Jan 5, 2026
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzz blizzz blizzz approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@come-nc come-nc Awaiting requested review from come-nc

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

@hamza221 hamza221 Awaiting requested review from hamza221 hamza221 is a code owner

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski SebastianKrupinski is a code owner

Assignees

@ArtificialOwl ArtificialOwl

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement feature: contacts

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

4 participants

@ArtificialOwl @blizzz @CarlSchwan @come-nc